RFR: 8331934: [s390x] Add support for primitive array C1 clone intrinsic [v3]

[Galder Zamarreño]

On Sat, 18 May 2024 14:05:52 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:
>> 
>>  - Merge master
>>  - s390x Port
>>  - Update src/hotspot/share/c1/c1_GraphBuilder.cpp
>>    
>>    Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>
>>  - Fix assert to only have a single !
>>  - Assert type is not interface
>>  - Remove whitespace
>>  - Expanded testing in TestNullArrayClone
>>    
>>    * Added byte[] and long[] tests.
>>    * Verified that the cloned array has the same contents.
>>    * Increase number of iterations reach tier 3 threshold.
>>  - Update src/hotspot/share/c1/c1_GraphBuilder.cpp
>>    
>>    Co-authored-by: Boris <42576543+bulasevich at users.noreply.github.com>
>>  - Added test summary
>>  - Use vmIntrinsics instead of vmIntrinsicID
>>  - ... and 16 more: https://git.openjdk.org/jdk/compare/2f10a316...865de5ba
>
> @galderz if possible can you review this ?
> 
> Maybe this could ease you a bit while review: Testing for `{tier1} X {fastdebug, slowdebug, release}` and `{tier1 -XX:TieredStopAtLevel=1} X {fastdebug, slowdebug, release}` was clean. Benchmarking also shows that we are good on this. You can check the result [here](https://github.com/openjdk/jdk/pull/19220#issuecomment-2115237059) :-)

@offamitkumar I'm no s390 expert, so I can only do a light review on the code. The changes look good to me and the benchmark results show improvements. One thing I would suggest is maybe expanding the testing a bit, e.g. hotspot_compiler, hotspot_gc, hotspot_serviceability, hotspot_runtime, and tier1-3 see https://github.com/openjdk/jdk/pull/17667#issuecomment-2071741244 for further details.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19220#issuecomment-2120755016