RFR: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) [v3]

[Fei Yang]

On Mon, 20 May 2024 10:22:26 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> For vector shift instruct, some corresponding tests are not enabled, this is to enable them.
>> And the way how vector shift instruct works is not clear, especially both vectorization (SLP in jdk) and Vector API share the same instruct's in riscv_v.ad, so also added some comment to clarify it.
>> 
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix misc

src/hotspot/cpu/riscv/riscv_v.ad line 1786:

> 1784: // vector shift
> 1785: //
> 1786: // Following shift instruct's are shared by vectorization (in SLP, superword.cpp) and vector API.

s/vector API/Vector API/

test/hotspot/jtreg/compiler/c2/aarch64/TestVectorShiftShorts.java line 31:

> 29:  *
> 30:  * @requires vm.compiler2.enabled
> 31:  * @requires os.arch == "aarch64"

Is this change still needed then?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19265#discussion_r1607490169
PR Review Comment: https://git.openjdk.org/jdk/pull/19265#discussion_r1607487356