RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v23]

[Emanuel Peter]

On Tue, 21 May 2024 06:07:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added comment about UseAPX and UseAVX > 2 correspondence
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1008:
> 
>> 1006:   if (UseAPX && (UseAVX < 3)) {
>> 1007:     if (!FLAG_IS_DEFAULT(UseAPX)) {
>> 1008:         warning("UseAPX is only available when UseAVX > 2");
> 
> Suggestion:
> 
>         warning("UseAPX is only available when UseAVX > 2. Disabling UseAPX.");

This would tell the user what we are doing, just like with the UseAVX flag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1607694409