RFR: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) [v4]
Fei Yang
fyang at openjdk.org
Tue May 21 07:58:03 UTC 2024
On Tue, 21 May 2024 07:41:27 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>> For vector shift instruct, some corresponding tests are not enabled, this is to enable them.
>> And the way how vector shift instruct works is not clear, especially both vectorization (SLP in jdk) and Vector API share the same instruct's in riscv_v.ad, so also added some comment to clarify it.
>>
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> minor
LGTM assuming these tests pass with RVV. Thanks.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19265#pullrequestreview-2067817780
More information about the hotspot-compiler-dev
mailing list