RFR: 8317720: RISC-V: Implement Adler32 intrinsic [v7]
Fei Yang
fyang at openjdk.org
Tue May 21 08:04:03 UTC 2024
On Mon, 20 May 2024 22:38:20 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:
>> I also ran the correctness test on the Banana Pi BPI-F3 board (has RVV1.0):
>>
>> Before this patch and disable UseRVV:
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is ok
>> Before this patch and enable UseRVV:
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is ok
>>
>> Apply this patch and disable UseRVV:
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is ok
>> Apply this patch and enable UseRVV:
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is Failed
>>
>> The TestAdler32.jtr on Failed is as follows:
>> [TestAdler32.jtr.log](https://github.com/openjdk/jdk/files/15350178/TestAdler32.jtr.log)
>
> Hello @zifeihan! Thanks for your efforts on improving this PR. I don't have access (yet) to Banana Pi board, so I can't debug precisely the case you pointed out. However, I know that vlen for Banana Pi is 256 bit, so I fixed problems for this case and checked functional correctness on QEMU for both 128 and 256 bit, which is OK now. Could you please do a re-run of `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` test?
@ArsenyBochkarev: Hi, Will take another look later this week. It seems that the JMH numbers on Banana Pi improved with your last 3 commits. Is that anticipated? BTW: You need to fix errors reported by jcheck.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18382#issuecomment-2122000787
More information about the hotspot-compiler-dev
mailing list