RFR: 8320448: Accelerate IndexOf using AVX2 [v20]
Scott Gibbons
sgibbons at openjdk.org
Wed May 22 02:07:36 UTC 2024
On Tue, 21 May 2024 18:03:41 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressing lots of comments. Interim commit.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4648:
>
>> 4646: vpxor(vec1, vec2);
>> 4647:
>> 4648: vptest(vec1, vec1);
>
> These should be only 128 bit:
> pxor(vec1, vec2);
> ptest(vec1, vec1);
Fixed
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1351:
>
>> 1349: assert_different_registers(needle, needleVal);
>> 1350:
>> 1351: bool isLL = (ae == StrIntrinsicNode::LL);
>
> isLL not used in this function.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1609164643
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1609164578
More information about the hotspot-compiler-dev
mailing list