RFR: 8325520: Vector loads with offsets incorrectly compiled [v12]

[Damon Fenacci]

On Wed, 22 May 2024 07:50:12 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8325520: add override keyword
>
> src/hotspot/share/opto/vectornode.hpp line 916:
> 
>> 914:   virtual int store_Opcode() const {
>> 915:     // Ensure it is different from any store opcode
>> 916:     return -1;
> 
> Maybe improve this comment and explain that we are doing this to avoid folding which does not account for the mask/offsets. Same for the comments in the other `store_Opcode` methods.

Comments updated.
Thanks @TobiHartmann!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1610136728