RFR: 8325520: Vector loads and stores with indices and masks incorrectly compiled [v12]

[Damon Fenacci]

On Tue, 21 May 2024 14:09:21 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Looks good now! Thanks for all the updates, I think now the fix looks really concise 😊 
>> 
>>> we add a specific store_Opcode method to LoadVectorGatherNode, LoadVectorMaskedNode and LoadVectorGatherMaskedNode that doesn’t return a store opcode but instead returns its own (to avoid ever being the same as a store node).
>> 
>> This part in the PR description could be updated: now we return `-1` for those that we think are not "comparable".
>
>> This part in the PR description could be updated: now we return `-1` for those that we think are not "comparable".
> 
> You're right. Fixed.
> Thanks a lot for the review @eme64!!

> @dafedafe I recommend that you update the Bug title. It names "offsets", but really you probably want to name "indices and mask", or just "masked and gather/scatter vector operations". And it also is not just about "loads", but also "stores", correct?

Yep. I changed the title... and adapted the description as well (offsets -> indices).
Thanks @eme64

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18347#issuecomment-2125010649