RFR: 8325520: Vector loads and stores with indices and masks incorrectly compiled [v11]

[Emanuel Peter]

On Thu, 23 May 2024 08:49:43 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> On macosx we build with the flag `-Winconsistent-missing-override` enabled, which seems to allow either no `override` anywhere or in all places where a method actually overrides another one. So, in this case it seems that we would either need to add `override`s to `virtual int Opcode()`, `virtual uint match_edge(uint idx)`, `virtual Node* Ideal(PhaseGVN* phase, bool can_reshape)` etc. in all classes, or remove the 4 `override` keywords from the `indices` and `mask` methods. I might opt for the second choice. @eme64 what do you think?
>
> The second choice makes sense to limit the scope of the changes in this PR. If we still want to add the `override` keywords, we should do that in a separate RFE.

Ah yes. I forgot about `-Winconsistent-missing-override`. No `override` keyword then 😞

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1611290337