RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v6]

Bhavana Kilambi bkilambi at openjdk.org
Thu May 23 10:15:08 UTC 2024


On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Moving array construction within BigInteger.implMultiplyToLen intrinsic candidate to its caller simplifies the intrinsic implementation in JIT compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comments.

src/hotspot/share/opto/library_call.cpp line 5925:

> 5923:   // Set the original stack and the reexecute bit for the interpreter to reexecute
> 5924:   // the bytecode that invokes BigInteger.multiplyToLen() if deoptimization happens
> 5925:   // on the return from z array allocation in runtime.

Since we are not allocating z array during runtime anymore, do we still need these comments?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1611403873


More information about the hotspot-compiler-dev mailing list