RFR: 8320448: Accelerate IndexOf using AVX2 [v19]

Volodymyr Paprotski duke at openjdk.org
Fri May 24 20:26:41 UTC 2024


On Wed, 22 May 2024 14:50:40 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> test/jdk/java/lang/StringBuffer/IndexOf.java line 284:
>> 
>>> 282: 
>>> 283:   // Note: it is possible although highly improbable that failCount will
>>> 284:   // be > 0 even if everthing is working ok
>> 
>> This sounds like either a bug or a testcase bug? Same as line 301, `extremely remote possibility of > 1 match`?
>
> This was there from the original author.  I think they were trying to infer that a match could occur in the rare case that the same random string was produced.  They're random after all, and there's no reason the same sequence could be generated.

Makes sense

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1613872215


More information about the hotspot-compiler-dev mailing list