RFR: 8332402: [IR Framework] Add tests for applyIfCPUFeature* and applyIfPlatform* in TestBadFormat

Ludovic Henry luhenry at openjdk.org
Mon May 27 08:41:25 UTC 2024


On Mon, 20 May 2024 08:27:33 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this patch to add some test for IR test framework?
> As discussed https://github.com/openjdk/jdk/pull/19270#pullrequestreview-2060974799, it's worth to add some tests for for applyIfCPUFeature* and applyIfPlatform* in TestBadFormat.
> 
> Thanks

Marked as reviewed by luhenry (Committer).

@chhagedorn @eme64 could you please review as you did the most recent changes on this file? Not sure who else to ping on this. Thank you!

-------------

PR Review: https://git.openjdk.org/jdk/pull/19302#pullrequestreview-2067817156
PR Comment: https://git.openjdk.org/jdk/pull/19302#issuecomment-2121993845


More information about the hotspot-compiler-dev mailing list