RFR: 8332402: [IR Framework] Add tests for applyIfCPUFeature* and applyIfPlatform* in TestBadFormat

Christian Hagedorn chagedorn at openjdk.org
Mon May 27 08:41:25 UTC 2024


On Tue, 21 May 2024 08:13:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Generally, the count is not always as I would expect. Can we fix that? You should at least comment what fails, and why.

I agree that this would be helpful when the count does not match the number of IR rules. You don't need to add it for existing tests where it is missing but at least it would be good for new tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19302#discussion_r1615636721


More information about the hotspot-compiler-dev mailing list