RFR: 8324756: Test vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize is too slow due to dependency verification [v5]

[Emanuel Peter]

On Wed, 15 May 2024 09:26:27 GMT, Ian Myers <imyers at openjdk.org> wrote:

>> This change removes dependency verification by passing -XX:-VerifyDependencies in the test.
>> 
>> `vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java` takes 20min to run on linux-x86_64-server-fastdebug:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java
>> CONF=linux-x86_64-server-fastdebug make test   **1412.82s user 15.27s system 115% cpu 20:41.19 total**
>> 
>> 
>> Passing -XX:-VerifyDependencies flag speeds up the run time to 1min:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java TEST_VM_OPTS="-XX:-VerifyDependencies"
>> CONF=linux-x86_64-server-fastdebug make test    **287.27s user 16.19s system 496% cpu 1:01.10 total**
>> 
>> 
>> Adding -XX:-VerifyDependencies to the test file accomplishes the same run time of 1min:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java
>> CONF=linux-x86_64-server-fastdebug make test   **272.33s user 14.56s system 464% cpu 1:01.75 total**
>
> Ian Myers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   [8324756] Remove dependency verification from vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java

Why is `VerifyDependencies` so slow in this test?

test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java line 168:

> 166:             MHTransformationGen.createAndCallSequence(retVal, dataSnapshot, _mh, _finalArgs, true);
> 167:         }
> 168:         

Suggestion:



Drive by suggestion to get the `rfr` label back ;)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19040#issuecomment-2135689070
PR Review Comment: https://git.openjdk.org/jdk/pull/19040#discussion_r1617603397