RFR: 8325155: C2 SuperWord: remove alignment boundaries [v2]

[Emanuel Peter]

On Tue, 28 May 2024 07:58:38 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into JDK-8325155-rm-alignment-boundaries
>>  - rm TODO
>>  - manual merge
>>  - revert a line, need to fix it different
>>  - improve comments
>>  - fix alignment
>>  - fix reductions
>>  - MaxI reduction over chars
>>  - Merge branch 'master' into JDK-8325155-rm-alignment-boundaries
>>  - Merge branch 'master' into JDK-8325155-rm-alignment-boundaries
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c4867c62...82c9a77a
>
> Great cleanup! I have some comments but otherwise, looks good.

Thanks @chhagedorn for the review! I think I addressed all your points. Except for this:

> You should mention here that this method finally adds a new pair to the _pairset. On a separate note, find_adjacent_memop_pairs_in_group() suggests that we find something but we actually "find and add" something without returning anything from the method. Should we make this more clear in the method name?

I have not yet found a better name. I think `find` is ok here. I guess we could have it be `find_and_add` but this seems unnecessarily long to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18822#issuecomment-2135777231