RFR: 8331117: [PPC64] secondary_super_cache does not scale well [v3]

Wed May 29 08:14:29 UTC 2024

On Wed, 29 May 2024 07:40:21 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adapt assertion. We sometimes have only 1 element in the secondary supers array.
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2201:
> 
>> 2199:   li(result, 1); // failure
>> 2200:   // We test the MSB of r_array_index, i.e. its sign bit
>> 2201:   bgt(CCR0, L_fallthrough);
> 
> This looks wrong. Should be greater or equal.

Right. Fixed. Thank you!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19368#discussion_r1618416597