RFR: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug" [v2]

[Fei Gao]

On Sat, 24 Feb 2024 09:17:04 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> @theRealAph thanks for your kind review. All comments inspired me a lot and helped me think more. Also, thanks for your help on fixing it!
>
>> @fg1417 are you still working on this?
> 
> The best thing to do now is to remove the failing assertion.

Thanks for your comments, @theRealAph @dean-long @eme64 .

In the new commit, I add the assertion back, which was removed temporarily in https://github.com/openjdk/jdk/commit/98f0b86641d. 

Also, as @dean-long suggested before, I fold the new `indOffIN<size>` into the existing `indOffI<size>` with a predicate to reduce duplicate code. To make the predicate work well, the new commit also applies some changes to the shared "adlc" part to insert necessary `()` for predicate in an `Operand`. After that, multiple arguments can be chained with logical `&&`, like we did for an `Instruction`.

Tier 1 - 3 passed on `x86` and `aarch64`.

Please help review. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16991#issuecomment-2136896213