RFR: 8333099: Missing check for is_LoadVector in StoreNode::Identity [v2]

[Christian Hagedorn]

On Wed, 29 May 2024 11:18:49 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) introduced a check for type equality in `StoreNode::Identity` in the specific case of a load vector followed by a store vector.
>> Unfortunately the memory node operand might actually not be of type `LoadVector`. So, before retrieving its type, a check for `is_LoadVector` is necessary.
>
> Damon Fenacci has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update test/hotspot/jtreg/compiler/vectorapi/TestIsLoadVector.java
>    
>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>  - Update test/hotspot/jtreg/compiler/vectorapi/TestIsLoadVector.java
>    
>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>  - JDK-8333099: add regression test

Thanks for adding a test!

test/hotspot/jtreg/compiler/vectorapi/TestIsLoadVector.java line 33:

> 31:  */
> 32: 
> 33:  public class TestIsLoadVector {

Suggestion:

public class TestIsLoadVector {

test/hotspot/jtreg/compiler/vectorapi/TestIsLoadVector.java line 61:

> 59:     for (int i = 0; i < 100; i++) {
> 60:         test();
> 61:     }

Suggestion:

      for (int i = 0; i < 100; i++) {
          test();
      }

-------------

PR Review: https://git.openjdk.org/jdk/pull/19449#pullrequestreview-2085102706
PR Review Comment: https://git.openjdk.org/jdk/pull/19449#discussion_r1618701854
PR Review Comment: https://git.openjdk.org/jdk/pull/19449#discussion_r1618702425