RFR: 8333099: Missing check for is_LoadVector in StoreNode::Identity [v3]
Tobias Hartmann
thartmann at openjdk.org
Wed May 29 11:29:35 UTC 2024
On Wed, 29 May 2024 11:25:55 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) introduced a check for type equality in `StoreNode::Identity` in the specific case of a load vector followed by a store vector.
>> Unfortunately the memory node operand might actually not be of type `LoadVector`. So, before retrieving its type, a check for `is_LoadVector` is necessary.
>
> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8333099: fix indentation
Looks good to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19449#pullrequestreview-2085125372
More information about the hotspot-compiler-dev
mailing list