RFR: 8320448: Accelerate IndexOf using AVX2 [v48]
Emanuel Peter
epeter at openjdk.org
Thu May 30 06:28:21 UTC 2024
On Thu, 30 May 2024 06:21:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove duplicate vm.compiler2.enabled
>
> test/jdk/java/lang/StringBuffer/ECoreIndexOf.java line 29:
>
>> 27: * @requires vm.cpu.features ~= ".*avx2.*"
>> 28: * @requires vm.compiler2.enabled
>> 29: * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+EnableX86ECoreOpts -XX:UseAVX=2 -Xbatch -XX:-TieredCompilation -XX:CompileCommand=dontinline,ECoreIndexOf.indexOfKernel ECoreIndexOf
>
> Does this test really need to be `avx2` specific? Does it even need to be C2 specific?
> Or can this run on all platforms?
Would be a shame to spend so much time on writing a test and then not apply it everywhere ;)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620017891
More information about the hotspot-compiler-dev
mailing list