RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v10]
Bhavana Kilambi
bkilambi at openjdk.org
Thu May 30 13:08:08 UTC 2024
On Thu, 30 May 2024 12:19:20 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> I am not sure which specific avx/sse features/versions support these operations. Is it ok to add -
>> `applyIfCPUFeatureOr = {"sve", "true", "avx", "true"}` ?
>> or maybe anyone with x86 knowledge who would work on adding strict ordering conditions in their backend (after this patch is merged) can also modify these two testcases accordingly? Also in the vectorapi case, I have included only specific shapes of Vectors where the Reduction nodes would be generated on aarch64. It may or may not be the case for x86 and they might have to add more tests accordingly.
>
> I don't fully know what is ok. I usually check this experimentally, and just put the lowest feature that makes my test pass.
>
> Do you have access to any x86 machine you could test this on?
Oh ok. Yes I do have an x86 machine to test on.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1620680288
More information about the hotspot-compiler-dev
mailing list