RFR: 8319822: Use a linear-time algorithm for assert_different_registers() [v6]

Kim Barrett kbarrett at openjdk.org
Fri May 31 22:00:15 UTC 2024


On Fri, 31 May 2024 15:52:31 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/share/asm/register.hpp line 273:
>> 
>>> 271: }
>>> 272: 
>>> 273: template<typename R, typename... Rx>
>> 
>> Rx is unused and not needed.  Similarly for 3-R overload.
>
> Isn't it? It seems to me to be used for the next line.

I think that comment about unused Rx was on the overload `different_registers(ARS<R>, R)`, which
had an Rx parameter in an old version of this change.  It's okay now.  And there's no longer any 3-R
overload.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16617#discussion_r1622966842


More information about the hotspot-compiler-dev mailing list