RFR: 8343297: Vector unsigned min/max test are failing with -Xcomp

[Tobias Hartmann]

On Fri, 1 Nov 2024 06:22:30 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86.ad line 6567:
>> 
>>> 6565: %}
>>> 6566: 
>>> 6567: instruct vector_uminmax_reg_masked(vec dst, vec src2, kReg mask) %{
>> 
>> Should `src2` be renamed to `src`?
>
> For predicated vector operations, we either populate destination vector lane with the result of the operation if the corresponding mask bit is true or else retain the original contents of lanes.
> `vec1.lanewise(VectorOperators.UMIN, vec2) 
> `
> Here, UMinVNode (vec1, vec2) IR has two source inputs, and two addr matcher pattern alias the first source and destination operand. So src2 looks appropriate and is inline with other predicated operation patterns.

Thanks for the clarification, makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21819#discussion_r1825479298