RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v11]

[Christian Hagedorn]

On Fri, 1 Nov 2024 07:59:32 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix distance assert
>
> src/hotspot/share/opto/mempointer.cpp line 52:
> 
>> 50: 
>> 51:   // Sort summands by variable->_idx
>> 52:   _summands.sort(MemPointerSummand::cmp_for_sort);
> 
> When you name the method something like `cmp_by_variable_idx`, then you could remove the comment.

Can you also add a comment that sorting it like that enables walking over the summands and combining the scales for the same nodes below?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1825556736