RFR: 8343153: compiler/codecache/CheckLargePages.java fails on linux with huge pages configured but its number set to 0 [v4]

[Damon Fenacci]

On Thu, 31 Oct 2024 07:40:27 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/codecache/CheckLargePages.java line 120:
>> 
>>> 118:                 // 1GB large pages configured but none available
>>> 119:                 "Failed to reserve and commit memory with given page size\\. " +
>>> 120:                 "req_addr: [^ ]+ size: 1[gG], page size: 1[gG], \\(errno = 12\\)");
>> 
>> Took me a while to figure that these are `OR` matches due to the `|` hiding at the end of the first line. Would it make sense to update the comment to something like this?
>> 
>>                 // 1GB large pages configured and available
>>                 "CodeCache:\\s+min=1[gG] max=1[gG] base=[^ ]+ size=1[gG] page_size=1[gG]|" +
>>                 // or 1GB large pages configured but none available
>
> Also, isn't there a `CodeCache:\` line in the output in the failing case as well that should be added here in the OR part?

Thanks @TobiHartmann for looking at it.
I've actually changed the test to follow @eastig's suggestion below and reverted these lines to their original state.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21757#discussion_r1825800157