RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v13]

[Emanuel Peter]

On Fri, 1 Nov 2024 12:31:50 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apply more suggestions from Christian
>
> src/hotspot/share/opto/mempointer.hpp line 400:
> 
>> 398: 
>> 399:   // Use case: exact aliasing and adjacency.
>> 400:   bool is_always_at_distance(const jint distance) const {
> 
> The "always" seems to refer to the `Always` but it reads like we are just curious about the distance. Is `is_always_and_at_distance()` more clear?

Hmm. Maybe I can call it `is_always_with_distance`? Because this would imply that the two pointers always have an aliasing with this exact distance.... so that would be fitting in its **meaning**. But yours is more exactly what id **does**.... hmm.. what do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1825844577