RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v13]

[Emanuel Peter]

On Fri, 1 Nov 2024 12:45:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apply more suggestions from Christian
>
> src/hotspot/share/opto/mempointer.hpp line 480:
> 
>> 478:   // We limit the number of summands to 10. Usually, a pointer contains a base pointer
>> 479:   // (e.g. array pointer or null for native memory) and a few variables.
>> 480:   static const int SUMMANDS_SIZE = 10;
> 
> Looks like a best guess. Maybe you can also explicitly mention that here. Otherwise, it's unclear how you came up with the value 10.

Ok, will do

> src/hotspot/share/opto/mempointer.hpp line 497:
> 
>> 495: 
>> 496: private:
>> 497:   MemPointerDecomposedForm(Node* pointer, const GrowableArray<MemPointerSummand>& summands, const NoOverflowInt con)
> 
> Same here, could `con` be passed by const reference since you create a copy from it anyway?

did that

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1825897645
PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1825898587