RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory [v2]

Vladimir Kozlov kvn at openjdk.org
Fri Nov 1 17:30:29 UTC 2024


On Fri, 1 Nov 2024 00:22:42 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> This PR adds a quick check + bail out in order to avoid excessive usage of slow checks. Especially, it avoids querying the available memory so often.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor improvements (review feedback).

Looks good.

src/hotspot/share/compiler/compileBroker.hpp line 90:

> 88:   CompileTask* _first_stale;
> 89: 
> 90:   volatile int _size;

Right. I was concern about concurrent access to this field.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21812#pullrequestreview-2410562706
PR Review Comment: https://git.openjdk.org/jdk/pull/21812#discussion_r1826100677


More information about the hotspot-compiler-dev mailing list