RFR: 8342662: C2: Add new phase for backend-specific lowering [v3]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Mon Nov 4 03:36:12 UTC 2024
On Thu, 31 Oct 2024 02:48:03 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> I would prefer to keep it as-is because `PhaseIterGVN::optimize` does a lot of logic that may not be relevant here (such as IGVN verification and IGV printing). This way we can avoid changes to IGVN in the future accidentally impacting lowering in unexpected ways.
>
> I actually think it is a good idea to have verification and printing. Since Lowering does IGVN-like transformations, they should behave in generally the same way. If it turns out that we actually need a separate entry then we can create it then.
I see, I can understand the benefit there. I think we'll still need to have a custom entry to collect the nodes to place on the worklist and filter based on platform, but we can use `optimize()` to replace the main loop.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21599#discussion_r1827154474
More information about the hotspot-compiler-dev
mailing list