RFR: 8341781: Improve Min/Max node identities [v3]

[Jasmine Karthikeyan]

On Fri, 1 Nov 2024 07:08:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Add platform checks to IR
>>  - Merge branch 'master' into minmax_identities
>>  - Suggestions from review
>>  - Min/Max identities
>
> test/hotspot/jtreg/compiler/c2/irTests/TestMinMaxIdentities.java line 120:
> 
>> 118: 
>> 119:     @Test
>> 120: //     @IR(applyIfPlatform = { "riscv64", "false" }, phase = { CompilePhase.BEFORE_MACRO_EXPANSION }, counts = { IRNode.MIN_L, "1" })
> 
> I would say you should make them negative for now, i.e. make them `failOn`. Otherwise we won't catch these cases when JDK-8307513 gets integrated ;)

Sounds good, I've pushed a commit that makes the tests pass now but fail when 8307513 is integrated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21439#discussion_r1827178087