RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v16]

Emanuel Peter epeter at openjdk.org
Mon Nov 4 10:35:16 UTC 2024


On Mon, 4 Nov 2024 07:20:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more review applications
>
> src/hotspot/share/opto/memnode.cpp line 2943:
> 
>> 2941:     return false;
>> 2942:   }
>> 2943:   return true;
> 
> You could directly return (I cannot create a code suggestion as it says "Applying suggestions on deleted lines is not supported"):
> 
> return pointer_def.is_adjacent_to_and_before(pointer_use);

Ah good idea

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1827512031


More information about the hotspot-compiler-dev mailing list