Integrated: 8343415: RISC-V: Increase maximum size of C2EntryBarrierStub by four

Fei Yang fyang at openjdk.org
Mon Nov 4 10:56:34 UTC 2024


On Fri, 1 Nov 2024 02:13:16 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, please consider this small change.
> 
> There is one jump to continuation (after nmethod entry barriers) in C2EntryBarrierStub [1].
> The current max_size setting assumes the distance is within 1MB, which means a simple `jal` instruction [2].
> So I just count one for this jump in [JDK-8343121](https://bugs.openjdk.org/browse/JDK-8343121). This doesn't seem to break for various tests. But I don't think there is a good reason for that assumption to stand. Instead, we should remove this constraint assuming a `auipc+jr` pair for this jump.
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/c2_CodeStubs_riscv.cpp#L66
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L965
> 
> Testing on linux-riscv64:
> - [x] tier1 (fastdebug build)

This pull request has now been integrated.

Changeset: 7f131a9e
Author:    Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7f131a9e1eb96d905a57f6e1e6fec2b7c7f725a4
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

8343415: RISC-V: Increase maximum size of C2EntryBarrierStub by four

Reviewed-by: rehn, fjiang

-------------

PR: https://git.openjdk.org/jdk/pull/21818


More information about the hotspot-compiler-dev mailing list