RFR: 8343506: [s390x] multiple test failures with ubsan

Dean Long dlong at openjdk.org
Mon Nov 4 20:52:28 UTC 2024


On Mon, 4 Nov 2024 05:27:59 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> This is trivial patch which fixes the error I am seeing on s390x, while running tier1 with ubsan enabled. Please see JBS for more details.

src/hotspot/cpu/s390/s390.ad line 2550:

> 2548: // Unsigned Integer Immediate: 9-bit
> 2549: operand SSlenDW() %{
> 2550:   predicate(Immediate::is_uimm8((julong)n->get_long()-1));

Suggestion:

  predicate(n->get_long() >= 1 && Immediate::is_uimm8((julong)n->get_long()-1));

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21864#discussion_r1828368759


More information about the hotspot-compiler-dev mailing list