RFR: 8343214: Fix encoding errors in APX New Data Destination Instructions Support [v6]

Tue Nov 5 07:05:28 UTC 2024

On Wed, 30 Oct 2024 09:47:05 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove comment where not required
>
> I think we should first check-in extended gtest asm validation script detecting these issues either before or along with this patch.

> Hi @jatin-bhateja, please see the updated code indicating the MAP4 comment next to the VEX_OPCODE.

The specification does not mention using 0F_3C for MAP4. I guess we are trying to be compatible with the GCC encoding scheme here.  Adding MAP4 in the comments is still better.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21770#issuecomment-2456386026