RFR: 8343070: Enable is_trace_align_vector when TraceSuperWord is set

Hamlin Li mli at openjdk.org
Tue Nov 5 11:57:33 UTC 2024


On Mon, 28 Oct 2024 07:08:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hi,
>> Can you help to review this simple patch?
>> Currently, in SuperWord::filter_packs_for_alignment(), there is some log not turned on when TraceSuperWord is set, but I think it should, as it's more convenient for users to debug.
>> Thanks!
>
> Ah, one more thing. I try to keep `SW_INFO` and `TraceSuperWord` in sync. So if we do decide to add `ALIGN_VECTOR` to `TraceSuperWord`, we should also add it to `SW_INFO`.

@eme64 Thanks for the information.
At first my thought was to make it easier to debug SLP process, as I observed some tests failure on riscv, but it won't print out the detailed failure reason. This pr made it easy to do so, but at the same time also introduce some verbose information unconditionally, which is not useful when there is no failure/rejection or when user don't care about it.
I don't find another more reasonable way to modify current log in SLP, I'll use `-XX:CompileCommand=TraceAutoVectorization,*::*,ALIGN_VECTOR` instead, and close this pr.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21715#issuecomment-2456973340


More information about the hotspot-compiler-dev mailing list