RFR: 8343555: RISC-V: make UseZvfh diagnostic option

[Fei Yang]

On Tue, 5 Nov 2024 10:48:25 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi,
>> Can you help to review this simple patch?
>> Previously this UseZvfh was changed from experimental to product because we have real hardware to verify the feature, but as pointed out by @RealFYang , this one should ber a diagnostic option, as we don't want to expose too many options to users.
>> Thanks
>
> Now we have normal and exprimental. Changing this one we would have also diagnostic.
> And some we get from hwprobe and some not, it's not easy to know which ones to manually turn on, etc...
> Wouldn't it make more sense to turn all options which may be enabled hwprobe to diagnostic instead?

> @robehn @RealFYang I guess you two have similar opinion now? but I could be wrong. Are you suggesting to turn all the Product options (retrieved by hwprobe) to DIAGNOSTIC?
> 
> I won't suggest to turn any EXPERIMENTAL to DIAGNOSTIC in this pr, as we need to test it on real hardware first, but if you've tested some of them on real hardware please let me know, I'll do it in this pr.

My personal opinion is that we can make following ones DIAGNOSTIC as well as they have been tested on real hardwares. I agree with you to leave the other EXPERIMENTAL ones as they are. We can still turn them DIAGNOSTIC in the future when the hardware is available for testing.


  product(bool, UseRVC, false, "Use RVC instructions")                           \
  product(bool, UseRVV, false, "Use RVV instructions")                           \
  product(bool, UseZba, false, "Use Zba instructions")                           \
  product(bool, UseZbb, false, "Use Zbb instructions")                           \
  product(bool, UseZbs, false, "Use Zbs instructions")                           \
  product(bool, UseZfh, false, "Use Zfh instructions")

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21885#issuecomment-2457040315