RFR: 8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr'

Christian Hagedorn chagedorn at openjdk.org
Tue Nov 5 15:19:29 UTC 2024


On Mon, 4 Nov 2024 09:23:16 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

> Printing incorrectly printed `nullptr` instead of `null`
> 
> Buggy:
> 
> 
> ScopeDesc(pc=0x0000000104c05468 offset=2e8):
>    java.lang.Class::desiredAssertionStatus at 20 (line 3984)
>    Locals
>     - l0: reg rfp [58],oop
>     - l1: stack[0],oop
>     - l2: nullptr
>     - l3: empty
>    Expression stack
>     - @0: nullptr
> 
> 
> Fixed:
> 
> 
> ScopeDesc(pc=0x0000000106fdd468 offset=2e8):
>    java.lang.Class::desiredAssertionStatus at 20 (line 3984)
>    Locals
>     - l0: reg rfp [58],oop
>     - l1: stack[0],oop
>     - l2: null
>     - l3: empty
>    Expression stack
>     - @0: null

Looks good and trivial.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21869#pullrequestreview-2415938204


More information about the hotspot-compiler-dev mailing list