RFR: 8343067: C2: revisit constant-offset AddP chains after successful input idealizations [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Nov 5 19:50:12 UTC 2024


On Tue, 5 Nov 2024 18:03:15 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Hoist changed offset input check
>
> src/hotspot/share/opto/phaseX.cpp line 1647:
> 
>> 1645:       if (u->is_Mem()) {
>> 1646:         worklist.push(u);
>> 1647:       } else if (n == use->in(AddPNode::Offset) &&
> 
> `n == use->in(AddPNode::Offset)` result can be saved outside loop in local var.

Thanks, done (commit deb7c4e1).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21898#discussion_r1829916712


More information about the hotspot-compiler-dev mailing list