RFR: 8343214: Fix encoding errors in APX New Data Destination Instructions Support [v7]

[Jatin Bhateja]

On Wed, 30 Oct 2024 09:05:50 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> Hi @vamsi-parasa, NDD is very flexible in terms of argument selection, i.e. ADDL NDD, SRC1 (ModRM.R/M), SRC2 (ModRM.REG) has opcode 0x01 Whereas, ADDL NDD, SRC1 (ModRM.REG), SRC2 (ModRM.R/M) has opcode 0x03
> 
> In this case, we are trying to match GCC encoding scheme.
> 
> Can you please add the following comment here since the argument nomenclature does not match with parameter nomenclature?
> 
> NDD shares its encoding bits with NDS bits for regular EVEX instruction. Therefore we are passing DST as the second argument to minimize changes in leaf level routine.

Thanks for addressing this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21770#discussion_r1830459760