RFR: 8343535: IGV: Colorize nodes on demand

Andrey Turbanov aturbanov at openjdk.org
Wed Nov 6 18:57:29 UTC 2024


On Wed, 6 Nov 2024 12:19:47 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> <img width="292" alt="color" src="https://github.com/user-attachments/assets/ea050a39-5f1e-456b-adaa-2102d78b0f60">
> 
> <img width="697" alt="pick" src="https://github.com/user-attachments/assets/67569b5d-1d74-4a93-8a97-bb37c5bc9f93">
> 
> <img width="428" alt="nodes" src="https://github.com/user-attachments/assets/c8a994e3-9946-42ae-8701-34223a000a0c">
> 
> Adds new option to IGV to color selected nodes:
> 1) select some nodes
> 2) `Ctrl + C` or `View` -> `Color action`
> 3) pick a color and apply

src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramScene.java line 226:

> 224: 
> 225:     public void colorSelectedFigures(Color color) {
> 226:         for (Figure figure :  model.getSelectedFigures()) {

Suggestion:

        for (Figure figure : model.getSelectedFigures()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21925#discussion_r1831556933


More information about the hotspot-compiler-dev mailing list