RFR: 8343724: [PPC64] Disallow OptoScheduling [v2]

Martin Doerr mdoerr at openjdk.org
Thu Nov 7 13:23:19 UTC 2024


On Thu, 7 Nov 2024 08:52:46 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move flag configuration to VM_Version::initialize(). Add EntryAlignment guarantee like on other platforms.
>
> src/hotspot/cpu/ppc/c2_init_ppc.cpp line 58:
> 
>> 56:     warning("OptoScheduling is not supported on this CPU.");
>> 57:     FLAG_SET_DEFAULT(OptoScheduling, false);
>> 58:   }
> 
> Makes sense but better do it in `VM_Version::initialize()` because `Compile::pd_compiler2_init()` is called after initialization of flags has been completed and the setting will not be shown with `PrintFlagsFinal`.
> I'd even suggest to move the other flag settings there with this PR.

This makes sense. Please see my update. I have also added `guarantee(CodeEntryAlignment >= InteriorEntryAlignment, "");` to `Compile::pd_compiler2_init()` which is there on other platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21935#discussion_r1832669129


More information about the hotspot-compiler-dev mailing list