RFR: 8343535: IGV: Colorize nodes on demand [v2]

[Christian Hagedorn]

On Fri, 8 Nov 2024 08:49:33 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> If the user selects a dark color, the node labels might become hard to read. Here's a simple change that addresses that by coloring the labels in white in that case. Please consider merging it into this PR:

Great idea!

> In my opinion, the IGV toolbar is already pretty crowded (this hurts most when opening two graphs side-by-side) and I would prefer not adding the color icon there

I agree with this. Maybe we should generally think about cleaning the toolbar and dropping some of the fewer used icons.
 
> On the other hand, we could add the action to the pop-up menu that's opened when right-clicking into a node or set of nodes. 

I thought about this, too. I think that would be quite handy and an intuitive thing to do when not being aware of the feature and checking if there is an option to do it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21925#issuecomment-2464190597