RFR: 8343535: IGV: Colorize nodes on demand [v4]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Fri Nov 8 10:50:06 UTC 2024
On Fri, 8 Nov 2024 10:32:32 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> <img width="292" alt="color" src="https://github.com/user-attachments/assets/ea050a39-5f1e-456b-adaa-2102d78b0f60">
>>
>> <img width="697" alt="pick" src="https://github.com/user-attachments/assets/67569b5d-1d74-4a93-8a97-bb37c5bc9f93">
>>
>> <img width="428" alt="nodes" src="https://github.com/user-attachments/assets/c8a994e3-9946-42ae-8701-34223a000a0c">
>>
>> Adds new option to IGV to color selected nodes:
>> 1) select some nodes
>> 2) `Ctrl + C` or `View` -> `Color action`
>> 3) pick a color and apply
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>
> move from toolbar to menu
Looks good, thanks Toby! I see that you also fixed the extra label color, nice! would be good to factor out that code together with that of `FigureWidget::getTextColor()`, but not a must.
-------------
Marked as reviewed by rcastanedalo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21925#pullrequestreview-2423381186
More information about the hotspot-compiler-dev
mailing list