RFR: 8343535: IGV: Colorize nodes on demand [v4]

Christian Hagedorn chagedorn at openjdk.org
Fri Nov 8 11:33:24 UTC 2024


On Fri, 8 Nov 2024 10:32:32 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> <img width="292" alt="color" src="https://github.com/user-attachments/assets/ea050a39-5f1e-456b-adaa-2102d78b0f60">
>> 
>> <img width="697" alt="pick" src="https://github.com/user-attachments/assets/67569b5d-1d74-4a93-8a97-bb37c5bc9f93">
>> 
>> <img width="428" alt="nodes" src="https://github.com/user-attachments/assets/c8a994e3-9946-42ae-8701-34223a000a0c">
>> 
>> Adds new option to IGV to color selected nodes:
>> 1) select some nodes
>> 2) `Ctrl + C` or `View` -> `Color action`
>> 3) pick a color and apply
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move from toolbar to menu

Looks good! Just tried it out. One more thing I've noticed: When selecting a color for a node and then trying to color another node, the color selection resets back to `#ffffff`. Would be nice if the last selection would have been stored. But I'm not sure how easy this is. Could also be done separately.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21925#pullrequestreview-2423469608


More information about the hotspot-compiler-dev mailing list