RFR: 8343535: IGV: Colorize nodes on demand [v7]

Christian Hagedorn chagedorn at openjdk.org
Fri Nov 8 15:15:30 UTC 2024


On Fri, 8 Nov 2024 14:53:53 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> <img width="292" alt="color" src="https://github.com/user-attachments/assets/ea050a39-5f1e-456b-adaa-2102d78b0f60">
>> 
>> <img width="697" alt="pick" src="https://github.com/user-attachments/assets/67569b5d-1d74-4a93-8a97-bb37c5bc9f93">
>> 
>> <img width="428" alt="nodes" src="https://github.com/user-attachments/assets/c8a994e3-9946-42ae-8701-34223a000a0c">
>> 
>> Adds new option to IGV to color selected nodes:
>> 1) select some nodes
>> 2) `Ctrl + C` or `View` -> `Color action`
>> 3) pick a color and apply
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright year

Great idea with the defaults! I've just tried it out on Linux. It does seem to remember my last choice and offers me some defaults. But somehow the window look off:

![image](https://github.com/user-attachments/assets/626f6aef-195a-4b37-9869-16e8ccf26517)

The defaults are hard to see and the rectangle saying "Preview" to the left is strange. It also says "Color Name: #ffffff" even though it chooses the last selected one correctly when pressing "OK".

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21925#issuecomment-2465002719


More information about the hotspot-compiler-dev mailing list