RFR: 8343745: Only update Last Value Assertion Predicates in Loop Unrolling [v3]

Christian Hagedorn chagedorn at openjdk.org
Mon Nov 11 06:54:32 UTC 2024


> (Note: This is a dependent PR on https://github.com/openjdk/jdk/pull/21944 which is fully reviewed but I'd prefer to integrate it on Monday and run again some testing over the weekend)
> 
> This is a follow-up feature to https://github.com/openjdk/jdk/pull/21944 which updated Loop Unrolling to use a new predicate visitor and enables this patch.
> 
> In Loop Unrolling, we only update the stride and not the init value of a loop. Thus, we actually only require to update the Last Value Assertion Predicates because the Init Value Assertion Predicates do not use `OpaqueLoopStride`. So, we also would not be required to kill the old Init Value Initialized Assertion Predicates. This patch implements that improvement.
> 
> To make this work, we need to query the associated `AssertionPredicateType` of an Assertion Predicate which is stored in the `If/RangeCheckNode` (I guess it's okay to have this additional node field in product). This was guarded by `NOT_PRODUCT` before. For this patch, I make this information available in product builds and use it to implement this feature.
> 
> Thanks,
> Christian

Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8343745
 - 8343745: Only update Last Value Assertion Predicates in Loop Unrolling
 - Add const
 - 8342946: Replace predicate walking code in Loop Unrolling with a predicate visitor

-------------

Changes: https://git.openjdk.org/jdk/pull/21969/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21969&range=02
  Stats: 130 lines in 7 files changed: 47 ins; 13 del; 70 mod
  Patch: https://git.openjdk.org/jdk/pull/21969.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21969/head:pull/21969

PR: https://git.openjdk.org/jdk/pull/21969


More information about the hotspot-compiler-dev mailing list