RFR: 8343629: More MergeStore benchmark [v2]

Emanuel Peter epeter at openjdk.org
Mon Nov 11 07:26:30 UTC 2024


On Sat, 9 Nov 2024 02:36:14 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> 1. Added the putBytes4 benchmark, which corresponds to StringBuilder appendNull
>> 2. Optimized the putChars4/setInt/setLong series of benchmarks to reduce extra overhead and more accurately reflect performance differences.
>
> Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - from @eme64 add MergeStoresDisabled
>  - Merge remote-tracking branch 'upstream/master' into merge_store_bench_202410
>  - Merge remote-tracking branch 'upstream/master' into merge_store_bench_202410
>  - Merge branch 'master' into merge_store_bench_202410
>  - add putBytes4 and improved put

test/micro/org/openjdk/bench/vm/compiler/MergeStoreBench.java line 1153:

> 1151:     }
> 1152: 
> 1153:     @Fork(value = 1, jvmArgsPrepend = {

Suggestion:

    @Fork(value = 1, jvmArgs = {

Can you make this change, and run the benchmarks again?
There was a recent JMH build script change, and all usages of `jvmArgsPrepend` in JMH tests were supposed to be changed to `jvmArgs`. I think in your case the flag is actually not applied.

Not sure if that is true, but it looks that way to me.

https://github.com/openjdk/jdk/pull/21800

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21659#discussion_r1836062193


More information about the hotspot-compiler-dev mailing list