RFR: 8343148: C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method [v4]

[theoweidmannoracle]

On Fri, 8 Nov 2024 17:41:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add set_root_as_ctrl
>
> src/hotspot/share/opto/loopopts.cpp line 195:
> 
>> 193:       set_root_as_ctrl(x);
>> 194:       continue;
>> 195:     }
> 
> This looks like "band-aid" - this should be assert. May be investigate in separate RFE.

I opened an RFE for this https://bugs.openjdk.org/browse/JDK-8343907

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21836#discussion_r1836126244