RFR: 8343805: RISC-V: JVM crashes on startup when disabling compressed instructions [v2]
Fei Yang
fyang at openjdk.org
Tue Nov 12 09:47:22 UTC 2024
On Tue, 12 Nov 2024 09:31:47 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/stubRoutines_riscv.hpp line 42:
>>
>>> 40: _initial_stubs_code_size = 10000,
>>> 41: _continuation_stubs_code_size = 2000,
>>> 42: _compiler_stubs_code_size = 45000,
>>
>> Hey, why do we remove the `ZGC_ONLY` here?
>
> Seems to me it could trigger the similar issue unexpectedly, because for now G1 is still the default one, developers could only test default one before push their code?
Yeah, I removed the `ZGC_ONLY` check as I think it doesn't seem necessary here. I simply did two jdk builds with and without the ZGC feature configured and compared the used compiler stubs from the log output. I witnessed no difference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21966#discussion_r1837785528
More information about the hotspot-compiler-dev
mailing list