RFR: 8343941: IGV: dump graph at different register allocation steps [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Nov 12 11:55:09 UTC 2024


On Tue, 12 Nov 2024 08:26:26 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Split FIXUP_SPILLS
>
> src/hotspot/share/opto/phasetype.hpp line 104:
> 
>> 102:   flags(POST_ALLOCATION_COPY_REMOVAL,   "Post-allocation copy removal") \
>> 103:   flags(MERGE_MULTIDEFS,                "Merge multiple definitions") \
>> 104:   flags(FIXUP_SPILLS,                   "Fix up spills") \
> 
> Should we split at the word boundary?
> Suggestion:
> 
>   flags(FIX_UP_SPILLS,                   "Fix up spills") \

Thanks, done in commit e44fa796.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22017#discussion_r1837972013


More information about the hotspot-compiler-dev mailing list